Introduce global decryption for SOPS age keys #1481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheuscscp
force-pushed
the
global-secret-based-decryption
branch
5 times, most recently
from
32501c9 to
296f534
Compare
matheuscscp
commented
Jul 6, 2025
Comment on lines
+221
to
+225
| // We handle the SOPS age global decryption separately, as most of the other | ||
| // decryption providers already support global decryption in other ways, and | ||
| // we don't want to introduce duplicate methods of achieving the same. | ||
| // Furthermore, allowing e.g. cloud provider credentials to be fetched | ||
| // from this global secret would prevent workload identity from working. |
Member
Author
There was a problem hiding this comment.
Emphasis on this comment. I considered making the controller flag more generic and cover the other SOPS decryption providers, but that's not a good idea after all.
Signed-off-by: Matheus Pimenta <[email protected]>
matheuscscp
force-pushed
the
global-secret-based-decryption
branch
from
296f534 to
30275f2
Compare
stefanprodan
approved these changes
Jul 7, 2025
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @matheuscscp please also add the flag to the docs website.
stefanprodan
added
enhancement
Member
Author
|
Website PR here: fluxcd/website#2287 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1465