Skip to content

Controller, bugfix: Call EventRecorder.AnnotatedEventf in a go-routine to make it non-blocking. #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Controller, bugfix: Call EventRecorder.AnnotatedEventf in a go-routine to make it non-blocking. #1479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions internal/controller/kustomization_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1156,14 +1156,19 @@ func (r *KustomizationReconciler) finalize(ctx context.Context,
func (r *KustomizationReconciler) event(obj *kustomizev1.Kustomization,
revision, originRevision, severity, msg string,
metadata map[string]string) {
if metadata == nil {
metadata = map[string]string{}
// Make a copy of the metadata map to avoid race conditions.
md := make(map[string]string)
if metadata != nil {
for k, v := range metadata {
md[k] = v
}
}

if revision != "" {
metadata[kustomizev1.GroupVersion.Group+"/"+eventv1.MetaRevisionKey] = revision
md[kustomizev1.GroupVersion.Group+"/"+eventv1.MetaRevisionKey] = revision
}
if originRevision != "" {
metadata[kustomizev1.GroupVersion.Group+"/"+eventv1.MetaOriginRevisionKey] = originRevision
md[kustomizev1.GroupVersion.Group+"/"+eventv1.MetaOriginRevisionKey] = originRevision
}

reason := severity
Expand All @@ -1176,7 +1181,9 @@ func (r *KustomizationReconciler) event(obj *kustomizev1.Kustomization,
eventtype = "Warning"
}

r.EventRecorder.AnnotatedEventf(obj, metadata, eventtype, reason, msg)
// Run the event recorder in a goroutine to not block the reconciliation loop.
// A deep copy of the object is passed to the goroutine to avoid race conditions.
go r.EventRecorder.AnnotatedEventf(obj.DeepCopy(), md, eventtype, reason, msg)
}

func (r *KustomizationReconciler) finalizeStatus(ctx context.Context,
Expand Down