Skip emitting events for suspended Kustomizations #1396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
If you want to have a test for this, I think I need some help how to reproduce this case in testing. |
norman-zon
force-pushed
the
suspension-event-log
branch
2 times, most recently
from
73e7eb5 to
aed4345
Compare
Member
|
Please squash the 2 commits into one, signoff and force push. To sign off the commit please see https://github.com/fluxcd/kustomize-controller/pull/1396/checks?check_run_id=38894311508 |
norman-zon
force-pushed
the
suspension-event-log
branch
2 times, most recently
from
f314c15 to
c46ef3a
Compare
stefanprodan
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
stefanprodan
requested changes
Apr 13, 2025
There are edge cases where a reonciliation can be triggered on a suspended Kustomization, mainly through changes in a source. In these cases a "no-op" reconciliation occurs, which can be confusing for the user. This returns early if the Kustomization ist suspended. Signed-off-by: Norman Stetter <[email protected]>
norman-zon
force-pushed
the
suspension-event-log
branch
from
c46ef3a to
2d89eb6
Compare
stefanprodan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are edge cases where a reconciliation can be triggered on a suspended Kustomization, mainly through changes in a source. In these cases a "no-op" reconciliation occurs, which can be confusing for the user. This PR prevents the controller from updating the status and issuing events.
Fix: fluxcd/flux2#5174