Additional values for commit message template #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigkevmcd
force-pushed
the
message-template-values
branch
from
215893c to
ba877df
Compare
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
Can you please add this field to the API docs along with an example
bigkevmcd
force-pushed
the
message-template-values
branch
from
fa5cbbe to
e10cfe0
Compare
stefanprodan
approved these changes
Oct 22, 2024
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @bigkevmcd 🥇
stefanprodan
added
enhancement
makkes
approved these changes
Oct 23, 2024
This adds .spec.git.commit.messageTemplateValues as a map of strings that can be used to supplement the rendering of the commit message template. Signed-off-by: Kevin McDermott <[email protected]>
Signed-off-by: Kevin McDermott <[email protected]>
bigkevmcd
force-pushed
the
message-template-values
branch
from
135fe06 to
189ba58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #679
This adds .spec.git.commit.messageTemplateValues as a map of strings that can be used to supplement the rendering of the commit message template.