Allow option to skip tenant namespace creation #5597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshuishere
force-pushed
the
skip-tenant-ns-create
branch
2 times, most recently
from
8e0a123 to
dfe7cbe
Compare
Contributor
Author
|
Hello, |
cmd/flux/create_tenant.go
Outdated
| createTenantCmd.Flags().StringSliceVar(&tenantArgs.namespaces, "with-namespace", nil, "namespace belonging to this tenant") | ||
| createTenantCmd.Flags().StringVar(&tenantArgs.clusterRole, "cluster-role", "cluster-admin", "cluster role of the tenant role binding") | ||
| createTenantCmd.Flags().StringVar(&tenantArgs.account, "with-service-account", "", "service account belonging to this tenant") | ||
| createTenantCmd.Flags().BoolVar(&tenantArgs.skipNamespace, "skip-namespace-create", false, "skip namespace creation (namespace must exist already)") |
Member
There was a problem hiding this comment.
This can just be --skip-namespace same flag we use for uninstall
Contributor
Author
There was a problem hiding this comment.
The flag is updated now.
anshuishere
force-pushed
the
skip-tenant-ns-create
branch
from
a354621 to
6d39708
Compare
Member
|
Please rebase your fork with upstream main and squash the commits into one and force push. This PR should contain a single commit. |
Add --skip-namespace flag to the 'create tenant' command to skip automatic namespace creation when the namespace already exists. Signed-off-by: Anshuman Singh <[email protected]>
anshuishere
force-pushed
the
skip-tenant-ns-create
branch
from
6d39708 to
0ba28f3
Compare
stefanprodan
approved these changes
Nov 21, 2025
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @anshuishere
stefanprodan
added
the
backport:release/v2.7.x
Member
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When flux onboards tenants in multitenant setup, it always creates manifest for namespace with no option to skip it.
When this is needed?
In a shared cluster, for example in a customer environment, namespaces are managed at infra level by cluster admin.
This means we receive a namespace already created and we don't want flux platform-admin to manage it or delete it in case of tenant removal.
What's in this PR?
This allows a flag to flux create tenant command to optionally skip namespace creation by flux. Default behaviour remains unchanged.