[video_player_platform_interface] Improve seek performance on Android#11932
[video_player_platform_interface] Improve seek performance on Android#11932sailendrabathi wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces backBufferDurationMs to VideoPlayerOptions to configure ExoPlayer's back buffer duration on Android, and adds videoPlayerOptions to VideoCreationOptions. Feedback suggests updating the assertion to allow a value of 0 (enabling developers to disable back buffering) and correcting the markdown spacing in the documentation comment for proper bold rendering.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
| }); | ||
| this.backBufferDurationMs, | ||
| }) : assert( | ||
| backBufferDurationMs == null || backBufferDurationMs >= 0, |
There was a problem hiding this comment.
On non-android implementations, isn't it going to be null?
There was a problem hiding this comment.
I didn't get you... the assert is that is should be null or non-negative. i.e it cannot be a non-null negative number
| final VideoPlayerWebOptions? webOptions; | ||
|
|
||
| /// **Android only**. Sets ExoPlayer's back buffer duration in milliseconds. | ||
| final int? backBufferDurationMs; |
There was a problem hiding this comment.
If you're asserting it must be non-null, why allow it to be nullable?
There was a problem hiding this comment.
The assert is that it can be null or non negative. i.e cannot be a non-null negative number
2 participants
Adds
backBufferDurationMstovideo_player_platform_interfaceThis PR has only the platform interface package changes from the main PR: #11810.
Following PR split as per Changing federated plugins
Pre-Review Checklist
[shared_preferences]///).