[camera_android_camerax] Setup agent skills camerax

.repo_tool_config.yaml

@@ -113,6 +113,7 @@ allowed_dependencies:
     # Google-owned packages
     - _discoveryapis_commons
     - adaptive_navigation
+    - dart_skills_lint
     - googleapis
     - googleapis_auth
     - json_annotation

packages/camera/camera_android_camerax/.agents/skills/.gitignore

@@ -0,0 +1,15 @@
+# Ignore everything by default
+*
+
+# Un-ignore specific checked-in skills
+# (Add specific contributor skills here as they are created)
+!check-readiness/
+!check-readiness/SKILL.md
+!check-readiness/scripts/
+!check-readiness/scripts/check.sh
+
+# Keep essential configuration and docs
+!.gitignore
+!README.md
+!ignore.json
+!flutter_skills_ignore.json

packages/camera/camera_android_camerax/.agents/skills/README.md

@@ -0,0 +1,8 @@
+# Agent Skills
+
+This directory contains skills intended for repository maintainers and contributors. Local, checked-in skills are evaluated by `dart_skills_lint` and should be configured to prevent publishing to pub.dev.
+
+**Note on Remotely Managed Skills:**
+Skills that are remotely defined and managed using `npx skills` should **not** be installed directly into this directory. Instead, they must be installed into the repository root's `third_party/` directory to comply with third-party code policies. Once installed there, they should be symlinked into this directory. 
+
+Please see the `third_party/README.md` file at the root of the repository for specific rules and instructions on adding new remote skills.

packages/camera/camera_android_camerax/.agents/skills/check-readiness/SKILL.md

@@ -0,0 +1,19 @@
+---
+name: check-readiness
+description: Run this skill to check if the repository is ready for new work. Use this skill whenever the user asks to "check readiness", "see if we are ready to start work", or when starting a new task in the camera_android_camerax package.
+metadata:
+  internal: true
+---
+# Check Readiness
+
+This skill verifies that the local environment is properly configured and clean before starting new work in the `camera_android_camerax` package.
+
+## Instructions
+Run the bundled verification script ([scripts/check.sh](scripts/check.sh)) to perform the automated environment checks:
+```bash
+bash .agents/skills/check-readiness/scripts/check.sh
+```
+
+### Handling the Results
+1. **If the script succeeds:** Inform the user that the environment is clean, dependencies are resolved, and it is ready for new work.
+2. **If the script fails:** Explain exactly which check failed (e.g., git is not clean, a symlink is broken, Flutter is missing from PATH) and offer to help resolve it.

packages/camera/camera_android_camerax/.agents/skills/check-readiness/scripts/check.sh

@@ -0,0 +1,55 @@
+#!/bin/bash
+# Copyright 2013 The Flutter Authors
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# Stop on first error
+set -e
+
+# Get the directory of this script, then go up to camera_android_camerax root
+SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
+CAMERAX_DIR="$SCRIPT_DIR/../../../.."
+
+echo "🔍 Checking if environment is ready for new work..."
+
+# 1. Check symlinks resolve
+echo "1️⃣  Checking skill symlinks..."
+broken_links=$(find "$CAMERAX_DIR/.agents/skills" -type l ! -exec test -e {} \; -print)
+if [ -n "$broken_links" ]; then
+  echo "❌ Error: Found broken symlinks in .agents/skills:"
+  echo "$broken_links"
+  exit 1
+fi
+echo "✅ All symlinks resolve correctly."
+
+# 2. Check git state
+echo "2️⃣  Checking git state..."
+# Check the whole repository git state
+if [ -n "$(git status --porcelain)" ]; then
+  echo "❌ Error: Git working directory is not clean. Please commit or stash your changes before starting new work."
+  exit 1
+fi
+echo "✅ Git working directory is clean."
+
+# 3. Check dart and flutter
+echo "3️⃣  Checking Flutter and Dart..."
+if ! command -v flutter &> /dev/null; then
+  echo "❌ Error: 'flutter' is not on the PATH."
+  exit 1
+fi
+if ! command -v dart &> /dev/null; then
+  echo "❌ Error: 'dart' is not on the PATH."
+  exit 1
+fi
+echo "✅ Flutter and Dart are on the PATH."
+
+# 4. Check dependencies in camera_android_camerax
+echo "4️⃣  Checking dependencies in camera_android_camerax..."
+cd "$CAMERAX_DIR"
+if ! flutter pub get; then
+  echo "❌ Error: Failed to resolve dependencies."
+  exit 1
+fi
+echo "✅ Dependencies are resolved and ready."
+
+echo "🎉 Environment is fully ready!"

packages/camera/camera_android_camerax/.agents/skills/dart-add-unit-test

@@ -0,0 +1 @@
+../../../../../third_party/dart-lang-skills/.agents/skills/dart-add-unit-test

packages/camera/camera_android_camerax/.agents/skills/dart-collect-coverage

@@ -0,0 +1 @@
+../../../../../third_party/dart-lang-skills/.agents/skills/dart-collect-coverage

packages/camera/camera_android_camerax/.agents/skills/dart-generate-test-mocks

@@ -0,0 +1 @@
+../../../../../third_party/dart-lang-skills/.agents/skills/dart-generate-test-mocks

packages/camera/camera_android_camerax/.agents/skills/dart-run-static-analysis

@@ -0,0 +1 @@
+../../../../../third_party/dart-lang-skills/.agents/skills/dart-run-static-analysis

packages/camera/camera_android_camerax/.agents/skills/flutter-add-integration-test

@@ -0,0 +1 @@
+../../../../../third_party/flutter-skills/.agents/skills/flutter-add-integration-test

packages/camera/camera_android_camerax/.agents/skills/grill-me

@@ -0,0 +1 @@
+../../../../../third_party/mattpocock-skills/.agents/skills/grill-me

packages/camera/camera_android_camerax/.agents/skills/receiving-code-review

@@ -0,0 +1 @@
+../../../../../third_party/obra-superpowers/.agents/skills/receiving-code-review

packages/camera/camera_android_camerax/.pubignore

@@ -0,0 +1 @@
+.agents/

packages/camera/camera_android_camerax/dart_skills_lint.yaml

@@ -0,0 +1,10 @@
+dart_skills_lint:
+  rules:
+    check-relative-paths: error
+    check-trailing-whitespace: error
+  directories:
+    - path: "skills"
+  individual_skills:
+    - path: ".agents/skills/check-readiness"
+      rules:
+        prevent-skills-sh-publishing: error

packages/camera/camera_android_camerax/pubspec.yaml

@@ -27,9 +27,15 @@ dependencies:
 
 dev_dependencies:
   build_runner: ^2.2.0
+  dart_skills_lint:
+    git:
+      url: https://github.com/flutter/skills.git
+      path: tool/dart_skills_lint
+      ref: 8f85e82be6da429980f7cfe84f2f214a06cbfee1
   flutter_test:
     sdk: flutter
   leak_tracker_flutter_testing: any
+  logging: ^1.2.0
   mockito: ^5.4.4
   pigeon: ^26.1.4
 

packages/camera/camera_android_camerax/skills/README.md

@@ -0,0 +1,3 @@
+# Published Skills
+
+This directory contains AI agent skills that are intended to be published to pub.dev.

packages/camera/camera_android_camerax/test/enforce_tracked_skills_internal_rule.dart

@@ -0,0 +1,76 @@
+// Copyright 2013 The Flutter Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import 'dart:io';
+
+import 'package:dart_skills_lint/dart_skills_lint.dart';
+
+/// A custom lint rule that enforces that all skills tracked in version control
+/// are marked as internal.
+///
+/// This rule is specifically used to prevent the accidental publishing of
+/// workspace-specific agent skills to the global public skills registry. It
+/// uses `git ls-files` to determine if a skill directory is checked into git,
+/// and if it is, strictly requires that the `metadata: internal: true`
+/// frontmatter is present in the `SKILL.md` file.
+class EnforceTrackedSkillsInternalRule extends SkillRule {
+  @override
+  String get name => 'enforce-tracked-skills-internal';
+
+  @override
+  AnalysisSeverity get severity => AnalysisSeverity.error;
+
+  @override
+  Future<List<ValidationError>> validate(SkillContext context) async {
+    // Check if any files in the skill directory are tracked in git
+    final ProcessResult processResult;
+    try {
+      processResult = await Process.run('git', ['ls-files', context.directory.path]);
+    } on ProcessException catch (e) {
+      return [
+        ValidationError(
+          ruleId: name,
+          severity: severity,
+          file: 'SKILL.md',
+          message:
+              'Failed to run git to check tracked status. Is git installed and on the PATH? Error: $e',
+        ),
+      ];
+    }
+    if (processResult.exitCode != 0) {
+      return [];
+    }
+    final String output = (processResult.stdout as String).trim();
+    if (output.isEmpty) {
+      // Not tracked by git, no enforcement needed
+      return [];
+    }
+
+    final Object? yaml = context.parsedYaml;
+    if (yaml is! Map) {
+      return [
+        ValidationError(
+          ruleId: name,
+          severity: severity,
+          file: 'SKILL.md',
+          message: 'Tracked skills must have "metadata: internal: true" in SKILL.md frontmatter.',
+        ),
+      ];
+    }
+
+    final Object? metadata = yaml['metadata'];
+    if (metadata is! Map || metadata['internal'] != true) {
+      return [
+        ValidationError(
+          ruleId: name,
+          severity: severity,
+          file: 'SKILL.md',
+          message: 'Tracked skills must have "metadata: internal: true" in SKILL.md frontmatter.',
+        ),
+      ];
+    }
+
+    return [];
+  }
+}

packages/camera/camera_android_camerax/test/validate_skills_test.dart

@@ -0,0 +1,34 @@
+// Copyright 2013 The Flutter Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import 'dart:async';
+
+import 'package:dart_skills_lint/dart_skills_lint.dart';
+import 'package:flutter/foundation.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:logging/logging.dart';
+
+import 'enforce_tracked_skills_internal_rule.dart';
+
+void main() {
+  test('Validate Skills', () async {
+    final Level oldLevel = Logger.root.level;
+    Logger.root.level = Level.ALL;
+    final StreamSubscription<LogRecord> subscription = Logger.root.onRecord.listen((record) {
+      debugPrint(record.message);
+    });
+
+    try {
+      final Configuration config = await ConfigParser.loadConfig();
+      final bool isValid = await validateSkills(
+        config: config,
+        customRules: [EnforceTrackedSkillsInternalRule()],
+      );
+      expect(isValid, isTrue, reason: 'Skills validation failed. See above for details.');
+    } finally {
+      Logger.root.level = oldLevel;
+      await subscription.cancel();
+    }
+  });
+}

script/tool/lib/src/publish_check_command.dart

@@ -190,20 +190,105 @@ class PublishCheckCommand extends PackageLoopingCommand {
       return true;
     }
 
-    if (!getBoolArg(_allowPrereleaseFlag)) {
-      return false;
-    }
-
     await stdOutCompleter.future;
     await stdInCompleter.future;
 
     final output = outputBuffer.toString();
+
+    // TODO(reidbaker): Remove this custom error handling for gitignored files
+    // once https://github.com/dart-lang/pub/issues/4841 is resolved.
+    if (await process.exitCode == 65 && _onlyPubignoreWarnings(output, package)) {
+      print('Ignoring warning about gitignored files because they are in .pubignore.');
+      return true;
+    }
+
+    if (!getBoolArg(_allowPrereleaseFlag)) {
+      return false;
+    }
+
     return output.contains('Package has 1 warning') &&
         output.contains(
           'Packages with an SDK constraint on a pre-release of the Dart SDK should themselves be published as a pre-release version.',
         );
   }
 
+  bool _onlyPubignoreWarnings(String output, RepositoryPackage package) {
+    if (!output.contains('Files that are checked in while gitignored:')) {
+      return false;
+    }
+
+    final warningCountRegex = RegExp(r'Package has (\d+) warning');
+    final Match? match = warningCountRegex.firstMatch(output);
+    if (match != null) {
+      final int count = int.parse(match.group(1)!);
+      if (count > 1) {
+        return false;
+      }
+    }
+
+    final List<String> lines = output.split('\n');
+    var inFilesSection = false;
+    final gitignoredFiles = <String>[];
+
+    for (final line in lines) {
+      if (line.trim() == 'Files that are checked in while gitignored:') {
+        inFilesSection = true;
+        continue;
+      }
+      if (inFilesSection) {
+        if (line.trim().isEmpty) {
+          continue;
+        }
+        if (line.startsWith('  ') && !line.startsWith('   ')) {
+          gitignoredFiles.add(line.trim());
+        } else if (!line.startsWith(' ')) {
+          inFilesSection = false;
+        }
+      }
+    }
+
+    if (gitignoredFiles.isEmpty) {
+      return false;
+    }
+
+    final io.File pubignoreFile = package.directory.childFile('.pubignore');
+    if (!pubignoreFile.existsSync()) {
+      return false;
+    }
+
+    final List<String> pubignoreLines = pubignoreFile
+        .readAsLinesSync()
+        .map((String line) => line.trim())
+        .where((String line) => line.isNotEmpty && !line.startsWith('#'))
+        .toList();
+
+    for (final file in gitignoredFiles) {
+      var isIgnored = false;
+      for (final ignoreRule in pubignoreLines) {
+        var rule = ignoreRule;
+        if (rule.startsWith('/')) {
+          rule = rule.substring(1);
+        }
+        if (rule.endsWith('/')) {
+          if (file.startsWith(rule)) {
+            isIgnored = true;
+            break;
+          }
+        } else {
+          if (file == rule || file.startsWith('$rule/')) {
+            isIgnored = true;
+            break;
+          }
+        }
+      }
+      if (!isIgnored) {
+        return false;
+      }
+    }
+
+    return true;
+  }
+
   /// Returns true if the package has been explicitly marked as not for
   /// publishing.
   bool _isMarkedAsUnpublishable(RepositoryPackage package) {