[google_maps_flutter] Add editable polyline and polygon support (web)#11920
Draft
lume-code wants to merge 1 commit into
Draft
[google_maps_flutter] Add editable polyline and polygon support (web)#11920lume-code wants to merge 1 commit into
lume-code wants to merge 1 commit into
Conversation
11 tasks
Subscribes to the platform interface `onPolylineEdited` / `onPolygonEdited` streams and dispatches them to the `onEdited` callbacks on `Polyline` / `Polygon`. Editing is currently only supported on web. Bumps to 2.18.0. Third of three PRs splitting flutter#11492; depends on google_maps_flutter_platform_interface 2.16.0 and google_maps_flutter_web 0.7.0.
5df3708 to
4a61bc3
Compare
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires the app-facing package up to the editable polyline/polygon edit events.
Changes —
google_maps_flutter(2.17.1 → 2.18.0)onPolylineEdited/onPolygonEditedstreams incontroller.dart.onEditedcallbacks onPolyline/Polygoningoogle_map.dart.editablechange propagation.Usage
Editing is currently web-only; the
editableproperty is silently ignored on Android and iOS.Part of #11492 · Interface PR: #11492 · Web PR: #11919 · Fixes flutter/flutter#71248
Pre-Review Checklist
[shared_preferences]///).Footnotes
See the test exemption and version/CHANGELOG exemption docs for details. ↩ ↩2