Skip to content

Conversation

pq
Copy link
Collaborator

@pq pq commented Aug 27, 2025

As of Java 20, URL(uri) is deprecated in favor of URI(uri).toURL().

See: https://bugs.openjdk.org/browse/JDK-8296385?jql=parent%3DJDK-8294241


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@pq pq requested a review from jwren August 27, 2025 22:19
@pq pq added the autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green. label Aug 27, 2025
@pq pq changed the title [CQ] migrate off deprecated URL constructor [CQ] migrate off deprecated URL constructor invocations Aug 27, 2025
Copy link
Member

@jwren jwren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tried this change myself, see PR #8319, but I haven't gone back to update the test which my change caused a failure for -- if this passes all the test but all means land it.

@pq
Copy link
Collaborator Author

pq commented Aug 27, 2025

Ah! I see. Yeah. The ticket is adding handling for IllegalArgumentExceptions.

Thanks!

@pq pq merged commit 6cee9cd into flutter:main Aug 27, 2025
7 checks passed
@pq pq deleted the cq_migrateDeprecatedURI_cons branch August 27, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants