Use gradle build directly for dev build #8387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes over to using gradle for writing the JX Browser key and setting the dev version number, which allows us to call
./gradlew buildfor building the dev release instead of using the plugin tool. Note that the plugin tool is still being used to upload the dev build to jetbrains.I think the next step is removing the gradle build command from the plugin tool and auditing the rest of the commands in the plugin tool to see if we can remove more. I ran a test of building dev from this branch, but I'll wait to make sure this works over the weekend before proceeding.