Remove code that is no more necessary for validating .strobe selector cheat#235
Open
piradata wants to merge 1 commit intoflukeout:developfrom
Open
Remove code that is no more necessary for validating .strobe selector cheat#235piradata wants to merge 1 commit intoflukeout:developfrom
piradata wants to merge 1 commit intoflukeout:developfrom
Conversation
… cheat
checkResults functions already prevents cheating with ".strobe" selector by comparing
`$(".table").html() == ruleTable.html()`
because
`ruleTable.find(rule).addClass("strobe");`
will never find anything if dependent on the .strobe class as
`ruleTable.find(".strobe").removeClass("strobe");`
removes the class right before
Author
|
anyone here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkResults functions already prevents cheating with
".strobe"selector by comparing$(".table").html() == ruleTable.html()because
ruleTable.find(rule).addClass("strobe");will never find anything if dependent on the
.strobeclass becauseruleTable.find(".strobe").removeClass("strobe");already removes the class right before :)