Skip to content

audit-fix(rollup): enforce minimum gaps between window params#49

Closed
d1r1 wants to merge 1 commit into
mainfrom
audit/fix-challenge-deadline-62
Closed

audit-fix(rollup): enforce minimum gaps between window params#49
d1r1 wants to merge 1 commit into
mainfrom
audit/fix-challenge-deadline-62

Conversation

@d1r1
Copy link
Copy Markdown
Contributor

@d1r1 d1r1 commented Apr 10, 2026

resolve issue https://github.com/sherlock-audit/2026-03-fluent-mar-20th-2026/issues/62

  • add MIN_PRECONFIRMATION/CHALLENGE/RESOLUTION constants
  • replace conditional if != 0 guards with unconditional requires
  • fix init order to match setter cross-validation deps
  • update tests for new minimum window constraints

  - add MIN_PRECONFIRMATION/CHALLENGE/RESOLUTION constants
  - replace conditional if != 0 guards with unconditional requires
  - fix init order to match setter cross-validation deps
  - update tests for new minimum window constraints
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 10, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c1606fe0-6275-4cac-93cd-6953f7d6fd30

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch audit/fix-challenge-deadline-62

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@d1r1 d1r1 changed the title fix(rollup): enforce minimum gaps between window params audit-fix(rollup): enforce minimum gaps between window params Apr 12, 2026
@chillhacker chillhacker deleted the audit/fix-challenge-deadline-62 branch May 12, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants