audit-fix(rollup,bridge): snapshot timing windows and freeze receive deadline#40
Closed
d1r1 wants to merge 2 commits into
Closed
audit-fix(rollup,bridge): snapshot timing windows and freeze receive deadline#40d1r1 wants to merge 2 commits into
d1r1 wants to merge 2 commits into
Conversation
- freeze submitBlobs/challenge/finalization windows per batch - admin updates no longer affect in-flight batches - pack 3×uint32 snapshots into existing BatchRecord slot - shrink acceptedAtBlock to uint48 for packing headroom - remove preconfirmWindow entirely, simplify corruption checks
- commit validUntilBlockNumber into L1->L2 message hash - move receiveMessageDeadline storage from L2 to L1 - reject zero deadline on L1 to prevent stuck funds - charge L2 send fee after snapshot to isolate treasury - require L1 block oracle unconditionally on L2 receive
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d1r1
changed the title
d1r1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve issue 50