fmpz_lll_mpf: use simple dot product instead of slow cancellation-checking dot product #2381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
fmpz_lll_check_babai_heuristic
, there is anmpf
dot product computation which attempts to guess if there is too much cancellation and then falls back to an exactfmpz
dot product. Looking at all calls to LLL that occur in our test suite, it seems that this fallback is very rarely useful, while the cancellation check costs more than the actual dot product. We could optimize the cancellation check, but let's try to simplify things and just skip it.It turns out that this gives a nearly 2x speedup in the polynomial factoring examples which are currently commented out in
build/fmpz_poly_factor/profile/p-factor_hard
due to being excessively slow.Old:
New: