feat: add validation for grid spacing in AutoGrid #2453
Conversation
| (3e21, True), # dl<1e-6 → fail | ||
| (1e14, False), # dl>1e-7 → pass | ||
| ], | ||
| ) |
There was a problem hiding this comment.
if you just make the simulation size 1e7 smaller wouldn't that avoid the long runtime of the test?
There was a problem hiding this comment.
Yes, it reduces the runtime. Thanks!
| ("freq0", "expect_error"), | ||
| [ | ||
| (3e21, True), # dl<1e-6 → fail | ||
| (1e14, False), # dl>1e-7 → pass |
| @@ -3596,6 +3619,9 @@ def _post_init_validators(self) -> None: | |||
| self._validate_custom_source_time() | |||
| self._validate_mode_object_bends() | |||
| self._warn_mode_object_pml() | |||
| _validate_min_grid_spacing( | |||
| self.grid, threshold=1e-7, msg_prefix=f"'{self.__class__.__name__}'" | |||
| ) | |||
There was a problem hiding this comment.
Let's do 1e-6, even that sounds too large, but to be consistent with the uniform grid validator. Or maybe we should increase the threshold for both? I don't know if I missed anything in the other discussion but wouldn't even 1e-5 be more than reasonable (hard to imagine any simulation that needs to go even below 1e-4). @yaugenst ?
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
| min_dy = dy[dy > 0].min() if np.any(dy > 0) else np.inf | ||
| min_dz = dz[dz > 0].min() if np.any(dz > 0) else np.inf | ||
| overall = min(min_dx, min_dy, min_dz) | ||
| if (overall < threshold) and not np.isclose(overall, threshold, rtol=1e-6): |
There was a problem hiding this comment.
style: Consider adding a more descriptive variable name than 'overall' since this represents the minimum grid spacing across all dimensions
Extend
Simulation._post_init_validatorsto compute the minimum cell size (dl) after AutoGrid construction and validate it against threshold [1e-7 µm]. Addresses this issue.Note: The pytest takes a lot of time and memory to run locally, because it builds the full grid before running the dl check.
Greptile Summary
Added validation to prevent numerical instability by enforcing minimum grid spacing (dl) of 1e-7 µm in AutoGrid calculations.
Simulation._post_init_validatorsto catch problematic small cell sizestest_autogrid_min_spacingwith both passing (freq0=1e14) and failing (freq0=3e21) test cases