[FXC-342] [FXC-343] Add output classes for imported surfaces #1352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifan-flex
changed the title
| def inject_imported_surface_info(entity: ImportedSurface): | ||
| """inject entity info""" | ||
| return { | ||
| "meshFile": entity.file_name, |
There was a problem hiding this comment.
Have we tested this e2e? Will backend normalize the file name after submitted to S3?
There was a problem hiding this comment.
We can't test e2e yet. Submission of imported surfaces will be handled by Feilin's view and edit feature.
| @@ -816,7 +901,17 @@ def translate_output(input_params: SimulationParams, translated: dict): | |||
| input_params, outputs, inject_isosurface_info | |||
| ) | |||
|
|
|||
| ##:: Step5: Get translated["monitorOutput"] | |||
| ##:: Step5: Get translated["importedSurfaceOutput"] | |||
| if has_instance_in_list(outputs, ImportedSurfaceOutput): | |||
There was a problem hiding this comment.
Translator unit tests?
| @@ -565,6 +565,17 @@ def _will_be_deleted_by_mesher(self, farfield_method: Literal["auto", "quasi-3d" | |||
| raise ValueError(f"Unknown auto farfield generation method: {farfield_method}.") | |||
|
|
|||
|
|
|||
| @final | |||
| class ImportedSurface(EntityBase): | |||
There was a problem hiding this comment.
What is the plan to add accessor in class Geometry for referencing ImprotedSurface?
There was a problem hiding this comment.
Waiting for Feilin's feature. We will more likely create a class parallel to Geometry. It will look something like project.imported_surfaces["*"].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.