adding secret vars as demo #75
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getvictor
reviewed
Jul 15, 2025
There was a problem hiding this comment.
The repo won't work when cloned unless they add a repo secret, right? And what about GitLab -- need instructions for that. Maybe we can keep this example on a branch or we can instead document how to explicitly enable this example? Like we comment out the script in the yaml file by default.
|
I tested it off a clone and it didn't throw an error but I will try it again just to double-check. But I also need to update the readme for GitLab -- good catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got a request to add an example of secret vars to the starter repo, added necessary files and update to the README.