print: add two new capabilities (n-copies and number-up) #1849
+34
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
have to bump the version of the frontend |
lbaudin
force-pushed
the
print-n-copies
branch
from
97b9883 to
ee94c82
Compare
Collaborator
|
The test rightfully fails. You need to adjust it. |
Both the app and the printer may be able to do copies. If the printer can do it, then it is likely more efficient and it should not be done in the app, so the app needs to know that the printer will do it. In the print dialog, the n-copies and number-up settings must be available if either the printer or the app can do it.
lbaudin
force-pushed
the
print-n-copies
branch
from
ee94c82 to
07da17d
Compare
Author
|
Oh right, it checked the version there. |
Author
|
Ping about this? (it leads to various annoying bugs with printing in gnome, so…) |
Collaborator
|
/ping @matthiasclasen @Sodivad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the app and the printer may be able to do copies. If the printer can do it, then it is likely more efficient and it should not be done in the app, so the app needs to know that the printer will do it.
Since the app may save print settings, we cannot just hide number-up and n-copies from the app, so we need both the app and the printer to advertise such capabilities if they are available.
Currently, this is not handled and n-copies is applied twice (so in GNOME documents are printed n-copies^2 times).
Related GNOME MR: https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/233