Skip to content

Conversation

@smcv
Copy link
Contributor

@smcv smcv commented Sep 30, 2025


@TheEvilSkeleton, was there a reason you didn't do this already in #206?

@TheEvilSkeleton
Copy link
Contributor

Yes, because the window explicitly states "NEW VERSION":

<property name="title">Portal Test NEW VERSION!!</property>

Since it wants us to use the GTK4 frontend, I didn't bother bumping the runtime for the GTK3 version.

@smcv
Copy link
Contributor Author

smcv commented Oct 1, 2025

That's been there since several years before the Gtk4 example was added. I don't think it means "you should use the new version instead", I think it means something more like "this is the new version of the Gtk3 portal test (integrated into libportal), not the old version (a standalone app)".

libportal should continue to have a Gtk 3 UI for as long as it has portal-gtk3.h, so that there's an easy way to do manual testing.

@TheEvilSkeleton
Copy link
Contributor

Fair. I haven't tested this MR, but if it works, perhaps we can merge it?

@smcv smcv requested a review from GeorgesStavracas October 1, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants