Improve error messages for invalid --forward-fd #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flatpak-spawn: Factor out parse_fd_option()
flatpak-spawn: Validate --forward-fd arguments early
This avoids accidentally forwarding a fd that flatpak-spawn opened for
its own purposes, like the signalfd for forward_signals(), which would
result in confusing error messages when flatpak-spawn tries to work
with a fd that has already been closed.
A frequent symptom of this is that apps that use a sandbox-escape via
flatpak-spawn --hostto mount FUSE filesystems hard-code that the$_FUSE_COMMFDis always going to be 3, which is not actually true(flatpak-spawn: Unable to read struct signalfd_siginfo: Bad file descriptor #46).