Skip to content

Add io.sourceforge.atanks#3449

Closed
Mailaender wants to merge 3 commits intoflathub:new-prfrom
Mailaender:atanks
Closed

Add io.sourceforge.atanks#3449
Mailaender wants to merge 3 commits intoflathub:new-prfrom
Mailaender:atanks

Conversation

@Mailaender
Copy link

Deprecate flathub/net.sourceforge.atanks#8 as upstream changed the application ID as SourceForge changed their URLs.

@Mailaender
Copy link
Author

bot, build io.sourceforge.atanks

@flathubbot
Copy link

Queued test build for io.sourceforge.atanks.

@flathubbot
Copy link

Started test build 107136

@flathubbot
Copy link

Build 107136 failed

@Mailaender
Copy link
Author

bot, build io.sourceforge.atanks

@flathubbot
Copy link

Queued test build for io.sourceforge.atanks.

@flathubbot
Copy link

Started test build 107140

@flathubbot
Copy link

Build 107140 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/104812/io.sourceforge.atanks.flatpakref

Co-authored-by: Hubert Figuière <hub@figuiere.net>
@barthalion
Copy link
Member

bot, build io.sourceforge.atanks

@flathubbot
Copy link

Queued test build for io.sourceforge.atanks.

@barthalion
Copy link
Member

I don't think it makes sense to rename the app only because Sourceforge changed its domain. Renaming is generally pretty disruptive process so we tend to avoid it unless the app is maintained by upstream.

@flathubbot
Copy link

Started test build 107636

@flathubbot
Copy link

Build 107636 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/105304/io.sourceforge.atanks.flatpakref

@Mailaender
Copy link
Author

Upstream changed the name in their metainfo file and as per policy this is maintained by them it leaves you no choice.

@hfiguiere
Copy link
Contributor

rename-appdata-file will actually take care of it.

@hfiguiere
Copy link
Contributor

it leave all the choice, including patching.

@Mailaender
Copy link
Author

I think that should be disallowed via @flathub guidelines.

@hfiguiere hfiguiere added the blocked Pull requests marked as blocked by reviewers label Aug 9, 2023
@bbhtt bbhtt changed the title Add Atomic Tanks again under new ID Add io.sourceforge.atanks May 11, 2024
@bbhtt bbhtt added the migrate-app-id Migrate an application to a new app-id label May 11, 2024
@github-actions
Copy link

This hasn't received any updates in 6 months and will be
automatically closed in 7 days. Please comment or reopen if
necessary.

@github-actions github-actions bot added the Stale Stale PR, no activity for over a year. Used by automated workflows. Do not modify label Mar 19, 2025
@github-actions github-actions bot closed this Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked Pull requests marked as blocked by reviewers migrate-app-id Migrate an application to a new app-id Stale Stale PR, no activity for over a year. Used by automated workflows. Do not modify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants