Skip to content

sys-kernel/coreos-modules: arm64: Enable CONFIG_FTRACE_SYSCALLS #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

arilou
Copy link
Contributor

@arilou arilou commented Jan 22, 2025

This config enables the syscall tracepoints which are mainly used by different security and observability tools.

Related to: flatcar/Flatcar#1617

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As this configuration has moved into the commonconfig file, we can remove it from the the amd64 config file as well:

A changelog entry will be needed similar to this PR: #2484

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I kicked-off a CI build. Changelog entry is still missing but it does not impact the CI run.

@arilou arilou force-pushed the arm64_enable_syscalls_tps branch 2 times, most recently from e9ddcf4 to 341f1e1 Compare January 22, 2025 08:54
@arilou
Copy link
Contributor Author

arilou commented Jan 22, 2025

Thanks! Done

@tormath1
Copy link
Contributor

@arilou image is available for download here: https://github.com/flatcar/scripts/actions/runs/12904571853/artifacts/2467235852 - can you give a try to see if it works as expected?

Failures in the CI are not related to this change (it happens when the test run from a fork).

Copy link

github-actions bot commented Jan 22, 2025

Build action triggered: https://github.com/flatcar/scripts/actions/runs/15993358226

@tormath1
Copy link
Contributor

@arilou image is available for download here: https://github.com/flatcar/scripts/actions/runs/12904571853/artifacts/2467235852 - can you give a try to see if it works as expected?

Failures in the CI are not related to this change (it happens when the test run from a fork).

LGTM but I will let you confirm:

core@localhost ~ $ zcat /proc/config.gz | grep CONFIG_FTRACE_SYSCALLS
CONFIG_FTRACE_SYSCALLS=y
core@localhost ~ $ uname -a
Linux localhost 6.6.71-flatcar #1 SMP PREEMPT Wed Jan 22 10:11:29 -00 2025 aarch64 GNU/Linux
core@localhost ~ $ sudo ls -l /sys/kernel/tracing/events/syscalls/ | head
total 0
-rw-r-----. 1 root root 0 Jan 22 13:28 enable
-rw-r-----. 1 root root 0 Jan 22 13:28 filter
drwxr-xr-x. 1 root root 0 Jan 22 13:28 sys_enter_accept
drwxr-xr-x. 1 root root 0 Jan 22 13:28 sys_enter_accept4
drwxr-xr-x. 1 root root 0 Jan 22 13:28 sys_enter_acct
drwxr-xr-x. 1 root root 0 Jan 22 13:28 sys_enter_add_key
drwxr-xr-x. 1 root root 0 Jan 22 13:28 sys_enter_adjtimex
drwxr-xr-x. 1 root root 0 Jan 22 13:28 sys_enter_arm64_personality
drwxr-xr-x. 1 root root 0 Jan 22 13:28 sys_enter_bind

@arilou
Copy link
Contributor Author

arilou commented Jan 22, 2025

Looks good! Thanks you

@tormath1
Copy link
Contributor

(FYI, I'm holding this PR until the current release is done to avoid any confusion)

@ader1990 ader1990 changed the title sys-kernel/coreos-modules: Enable CONFIG_FTRACE_SYSCALLS sys-kernel/coreos-modules: arm64: Enable CONFIG_FTRACE_SYSCALLS Feb 11, 2025
@tormath1
Copy link
Contributor

Hello @arilou,

I am sorry it's on me, I totally dropped the ball on this. Any chance to rebase this PR on current main branch? This will have a small conflict because Kernel has been upgraded from 6.6 to 6.12, as it is a two line changes, I would suggested to simply restart from scratch instead of rebasing with git.

I am so sorry again. 🙏

@arilou arilou force-pushed the arm64_enable_syscalls_tps branch from 341f1e1 to b422151 Compare June 29, 2025 05:55
@arilou
Copy link
Contributor Author

arilou commented Jun 29, 2025

Done

@tormath1
Copy link
Contributor

Done

Thanks, it looks like the 6.12 changes have not been pushed? I only see the changelog entry: https://github.com/flatcar/scripts/pull/2600/files

This config enables the syscall tracepoints which are mainly used by
different security and observability tools.

The config was moved to common, so it's removed from the AMD64 only
config.

Signed-off-by: Jon Doron <[email protected]>
@arilou arilou force-pushed the arm64_enable_syscalls_tps branch from b422151 to 4e23074 Compare June 30, 2025 08:13
@arilou
Copy link
Contributor Author

arilou commented Jun 30, 2025

My bad sorry, fixed

@tormath1 tormath1 merged commit 5d21109 into flatcar:main Jul 1, 2025
6 of 10 checks passed
@github-project-automation github-project-automation bot moved this from ✅ Testing / in Review to Implemented in Flatcar tactical, release planning, and roadmap Jul 1, 2025
@tormath1
Copy link
Contributor

tormath1 commented Jul 1, 2025

Thanks a lot @arilou this will be available in next Alpha and Beta releases.

Cherry-picked to:

  • flatcar-4372
  • flatcar-4344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants