Skip to content

Always send get_payload to builder #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 6, 2025

Conversation

SozinM
Copy link
Collaborator

@SozinM SozinM commented Aug 1, 2025

We encountered a problem that if builder does not receive getPayload it will not preserve current executed block to the cache. This change fix this, but adds a little bit of latency in the hot path of flashblocks

Copy link

vercel bot commented Aug 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
rollup-boost ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2025 3:56pm

Copy link
Collaborator

@avalonche avalonche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not spawn a new task and use channels to get the result back? it would not increase latency on the hot path

Copy link
Collaborator

@0xOsiris 0xOsiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. Seems like a better solution will be caching pre-confirmations in the builder, but should work as a temp patch.

@SozinM SozinM enabled auto-merge (squash) August 6, 2025 15:55
@SozinM SozinM force-pushed the msozin/always-send-get_payload-to-get-builder branch from 4ad24e4 to c8d53e4 Compare August 6, 2025 15:56
@SozinM SozinM merged commit 81c0699 into main Aug 6, 2025
8 of 9 checks passed
@SozinM SozinM deleted the msozin/always-send-get_payload-to-get-builder branch August 6, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants