Skip to content

feat: use at most builder balance for bid #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

efbig
Copy link
Collaborator

@efbig efbig commented Jul 29, 2025

πŸ“ Summary

Use at most builder balance for bid.


βœ… I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@efbig efbig requested review from dvush and ZanCorDX as code owners July 29, 2025 14:22
Copy link
Contributor

@dvush dvush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this will work because of delayed refunds.

I think its better to do this in a bidding service.
Give it builder balance and make sure it never asks to bid more than a balance.

Or more simply we can do that on our side where we receive response from a bidding service and cap payout to max of what we can pay.

This way we don't touch this brittle logic of payout out and we just modify the only input to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants