Refactor payload builder to accept generic builder tx #217
+745
−392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
commented
Jul 28, 2025
| if let Some(flashtestations_builder_tx) = &self.flashtestations_builder_tx { | ||
| // We only include flashtestations txs in the last flashblock | ||
|
|
||
| let mut simulation_state = self.simulate_builder_txs_state::<FlashblocksExtraCtx>( |
There was a problem hiding this comment.
returns empty vec for now
avalonche
commented
Jul 28, 2025
| } | ||
| } | ||
|
|
||
| pub fn simulate_builder_tx<ExtraCtx: Debug + Default>( |
There was a problem hiding this comment.
replace with flashblocks builder tx contract call
SozinM
requested changes
Jul 29, 2025
Co-authored-by: Solar Mithril <[email protected]>
Co-authored-by: Solar Mithril <[email protected]>
Co-authored-by: Solar Mithril <[email protected]>
avalonche
force-pushed
the
builder-tx
branch
2 times, most recently
from
f378fbf to
4e28c2e
Compare
Co-authored-by: Solar Mithril <[email protected]>
avalonche
force-pushed
the
builder-tx
branch
from
4e28c2e to
c461c24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Refactor to allow the payload builder accept generics for how to construct the builder tx.
💡 Motivation and Context
Easier to add custom logic to builder tx based on the payload builder such as contract calls etc.
✅ I have completed the following steps:
make lintmake test