Improve notification silence docs #394
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for flanksource-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for canarychecker canceled.
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates several submodule references and enhances the documentation for notification silences by adding a detailed reference MDX and reorganizing the conceptual guide.
- Bump submodule commits in multiple
modules/*and the rootmission-control-chart - Introduce
_silence.mdxto document silence fields and resource selector schema - Revise
silences.mdxguide with an import, example fixture, and clearer sections on creation, filters, and recursion
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/mission-control-registry | updated subproject commit |
| modules/mission-control-chart | updated subproject commit |
| modules/mission-control | updated subproject commit |
| modules/duty | updated subproject commit |
| modules/canary-checker | updated subproject commit |
| mission-control-chart | updated subproject commit |
| mission-control/docs/reference/notifications/_silence.mdx | new reference doc for silence API fields |
| mission-control/docs/guide/notifications/concepts/silences.mdx | restructured guide with import, example block, and sections |
|
Can we add an example of a filter in a full spec. The selectors table also seems incomplete. |
moshloop
reviewed
May 30, 2025
adityathebe
force-pushed
the
docs/silences-crd
branch
from
e3a36a7 to
ed20f04
Compare
|
adityathebe
force-pushed
the
docs/silences-crd
branch
from
0d4f6eb to
05bb0e3
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adityathebe
force-pushed
the
docs/silences-crd
branch
from
05bb0e3 to
4c2741b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #389