-
Notifications
You must be signed in to change notification settings - Fork 122
add qwen3-8b with megatron v0.15.0rc5 #914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a training configuration for the qwen3-8b model. While the changes align with the PR's goal, the new configuration file examples/qwen3/conf/train/8b.yaml contains critical issues. Specifically, it uses a placeholder for the data_path and an incorrect tokenizer_path which points to a tokenizer for a different model. These will prevent the training from running correctly. I have also suggested a minor improvement for consistency in boolean value representation.
|
|
||
|
|
||
| data: | ||
| data_path: /path/to/dataset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| no_mmap_bin_files: true | ||
| tokenizer: | ||
| tokenizer_type: HuggingFaceTokenizer | ||
| tokenizer_path: examples/aquila/tokenizer_hf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tokenizer_path is set to examples/aquila/tokenizer_hf, which is intended for an Aquila model and uses a GPT2Tokenizer. Using a tokenizer that does not match the qwen3-8b model will result in incorrect tokenization, leading to failed training or a poorly performing model. This path must be updated to point to the correct tokenizer for qwen3-8b.
| reset_position_ids: True | ||
| reset_attention_mask: True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The boolean values are specified as True with an uppercase 'T'. While many YAML parsers accept this, the YAML specification and best practices favor lowercase true and false. For consistency with other boolean values in this file (e.g., disable_bias_linear: true) and to ensure compatibility across different environments, these should be changed to lowercase.
reset_position_ids: true
reset_attention_mask: true|
shaojunsong seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
PR Category
PR Types
PR Description