[Diffusion] add TorchCompileTransformation #913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legitnull
changed the title
youth123
reviewed
Nov 11, 2025
| -1, | ||
| _users=2, # The cat feeds both slices | ||
| ) | ||
| slice_hi = CallFunction(aten.slice.Tensor, inner_cat, 1, split_idx, 9223372036854775807) |
There was a problem hiding this comment.
I still don't quite understand why it has to be written this way. Why not just write -1 directly?
Collaborator
Author
There was a problem hiding this comment.
I didn't dig into it. Maybe it has something to do with how aten.slice represent end of the dim
youth123
reviewed
Nov 11, 2025
| previous = torch._inductor.config.post_grad_custom_post_pass | ||
|
|
||
| if not pass_manager.empty(): | ||
| torch._inductor.config.post_grad_custom_post_pass = pass_manager |
There was a problem hiding this comment.
We should consider the four situations: pre_forward, post_forward, pre_backward, and post_backward, rather than just post_backward alone.
Collaborator
Author
There was a problem hiding this comment.
ok, let me check the torch api
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Inference
PR Types
New Features
PR Description
TorchCompileTransformation1.1 Apply torch.compile on target module
1.2 A backend wrapper to support custom passes
TimestepEmbeddingFlipSineCosinePass) to test the custom pass functionality