-
Notifications
You must be signed in to change notification settings - Fork 124
[Train] Fix tokenizer bug in training yaml #888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…e of the sample model.
Summary of ChangesHello @chai-xiaonan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a compatibility issue that arose after a Megatron version update, which caused errors related to tokenizer paths in various example models. By consistently adding the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
收到,谢谢
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a runtime error in the example models by adding the legacy_tokenizer: true option to their YAML configurations. The change is applied consistently across all affected files. I've added one comment regarding the use of a legacy flag, suggesting a future migration to the new tokenizer implementation for better long-term maintainability. Overall, the changes are good and address the described issue.
| data_path: ${data_path:??} | ||
| split: 1 | ||
| tokenizer: | ||
| legacy_tokenizer: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While adding legacy_tokenizer: true correctly resolves the immediate issue, it introduces technical debt by relying on a legacy implementation. For long-term maintainability, it would be beneficial to create a follow-up task to migrate all affected example configurations to the new tokenizer implementation. This would ensure the examples stay aligned with the latest framework features.
|
|
|
收到,谢谢
|
Uh oh!
There was an error while loading. Please reload this page.