Skip to content

Conversation

@chai-xiaonan
Copy link
Contributor

@chai-xiaonan chai-xiaonan commented Oct 30, 2025

  • configure "legacy_tokenizer: true" in the YAML files of all training models to accommodate the newest Megatron-LM

@chai-xiaonan chai-xiaonan requested a review from a team as a code owner October 30, 2025 07:33
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chai-xiaonan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a compatibility issue that arose after a Megatron version update, which caused errors related to tokenizer paths in various example models. By consistently adding the legacy_tokenizer: true configuration to the YAML files of these models, the PR ensures that the examples can run correctly with the updated Megatron environment, preventing runtime errors and maintaining functional integrity.

Highlights

  • Megatron Version Compatibility: Resolved an error related to "tokenizer_path" that occurred after updating to a new Megatron version by introducing the legacy_tokenizer: true option in several example model configurations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@chai-xiaonan
Copy link
Contributor Author

chai-xiaonan commented Oct 30, 2025 via email

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a runtime error in the example models by adding the legacy_tokenizer: true option to their YAML configurations. The change is applied consistently across all affected files. I've added one comment regarding the use of a legacy flag, suggesting a future migration to the new tokenizer implementation for better long-term maintainability. Overall, the changes are good and address the described issue.

data_path: ${data_path:??}
split: 1
tokenizer:
legacy_tokenizer: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While adding legacy_tokenizer: true correctly resolves the immediate issue, it introduces technical debt by relying on a legacy implementation. For long-term maintainability, it would be beneficial to create a follow-up task to migrate all affected example configurations to the new tokenizer implementation. This would ensure the examples stay aligned with the latest framework features.

@lxd-cumt lxd-cumt changed the title Add the "legacy_tokenizer: true" option to the YAML configuration file of the sample model. [Train] Fix tokenizer bug in training yaml Oct 30, 2025
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@chai-xiaonan
Copy link
Contributor Author

chai-xiaonan commented Nov 18, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants