add description of each data port #1301
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| m_basePosOut("basePosOut", m_basePos), // ベースリンク位置出力値 | ||
| m_baseRpyOut("baseRpyOut", m_baseRpy), // ベースリンク姿勢出力値 (rpy) | ||
| m_baseTformOut("baseTformOut", m_baseTform), // ベースリンク位置姿勢 (matrix) | ||
| m_basePoseOut("basePoseOut", m_basePose), // ベースリンク位置姿勢 (rpy) |
Contributor
There was a problem hiding this comment.
(basePos,baseRpy), baseTform, basePose は同じ値で、表現形式が違うという理解でいいかな？
Contributor
Author
There was a problem hiding this comment.
はい，どういう経緯でそうなったかわかりませんが（使いたい側でm_baseTformから適宜変換すればいい気がします），表現が違うだけで元の中身は同じものです．
rtc/AutoBalancer/AutoBalancer.cpp
Outdated
| m_qRefIn("qRef", m_qRef), // 関節角度入力値 | ||
| m_basePosIn("basePosIn", m_basePos), // ベースリンク位置入力値 | ||
| m_baseRpyIn("baseRpyIn", m_baseRpy), // ベースリンク姿勢入力値 (rpy) | ||
| m_zmpIn("zmpIn", m_zmp), // ZMP 入力値 (腰座標) |
Contributor
There was a problem hiding this comment.
腰座標はベースリンク位置姿勢と同じかな？
Contributor
Author
There was a problem hiding this comment.
同じものなので，ベースリンクで統一してpush -fしました．
| m_diffCPOut("diffCapturePoint", m_diffCP), // Capture Point 誤差 (world 座標) | ||
| m_diffFootOriginExtMomentOut("diffFootOriginExtMoment", m_diffFootOriginExtMoment), // モーメント誤差 (支持脚座標) | ||
| m_actContactStatesOut("actContactStates", m_actContactStates), // 各脚の実接触状態 (false: 遊脚, true: 支持脚) | ||
| m_COPInfoOut("COPInfo", m_COPInfo), // (COP 計算に必要な)各足に作用するモーメント (end-effector 座標) |
Contributor
There was a problem hiding this comment.
end-effector 座標 は 支持脚座標と同じかな？
Contributor
Author
There was a problem hiding this comment.
支持脚座標系は接地している足のセンサリンクの中間点で，かつz座標が常に鉛直方向を向くように変換しなおした座標系です．（xyはセンサリンクの中間座標と同じ向きです）
YutaKojio
force-pushed
the
add-port-description
branch
from
66717e5 to
7b28781
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@YoheiKakiuchi
このような感じでよろしいでしょうか．