Feature/new union macro metadata fields and variable configs by fivetran-savage · Pull Request #140 · fivetran/dbt_stripe

fivetran-savage · 2026-02-04T22:28:15Z

PR Overview

Package version introduced in this PR:

1.5.0

This PR addresses the following Issue/Feature(s):

Summary of changes:

Adds new union data macro to package
Pulls metadata fields from four staging models through to end models
Adds variable configs for payouts and transfers.

Submission Checklist

Alignment meeting with the reviewer (if needed)
- Timeline and validation requirements discussed
Provide validation details:
- Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
- Testing Instructions: Confirm the change addresses the issue(s)
- Focus Areas: Complex logic or queries that need extra attention
Merge any relevant open PRs into this PR

Changelog

Draft changelog for PR
Final changelog for release review

fivetran-joemarkiewicz

@fivetran-savage great work on this PR! A few comments before approving. Let me know if you have any questions, thanks!

integration_tests/tests/consistency/consistency_invoice_line_item_details.sql

integration_tests/tests/consistency/consistency_subscription_details.sql

macros/union/union_connections.sql

README.md

CHANGELOG.md

.quickstart/quickstart.yml

macros/select_metadata_columns.sql

.quickstart/quickstart.yml

fivetran-joemarkiewicz

@fivetran-savage this PR is looking good and close to approval! A few more comments before approval

.quickstart/quickstart.yml

integration_tests/tests/consistency/consistency_invoice_line_item_details.sql

CHANGELOG.md

macros/select_metadata_columns.sql

README.md

Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>

README.md

CHANGELOG.md

models/stripe__subscription_details.sql

models/stripe__balance_transactions.sql

models/stripe__customer_overview.sql

README.md

fivetran-joemarkiewicz

LGTM once above suggestions are applied, docs are generated, and integration tests are passing. Great work!

Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>

fivetran-avinash

@fivetran-savage Looking good, great updates!

A host of minor tweaks and updates, then a few doc requests before approval.

CHANGELOG.md

README.md

models/stripe__customer_overview.sql

CHANGELOG.md

models/stripe__invoice_details.sql

models/stripe__invoice_line_item_details.sql

models/stripe__subscription_details.sql

fivetran-avinash · 2026-02-12T01:39:54Z

models/stripe__subscription_details.sql


 ), subscription_item as (

    select *


looks like this was one of two ctes that didn't get an indent update so it looks slightly off

models/stripe__customer_overview.sql

Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com> Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>

Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>

CHANGELOG.md

Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>

fivetran-avinash

@fivetran-savage Some final comments + reverting the indentation updates as discussed before approval.

README.md

CHANGELOG.md

models/stripe__subscription_details.sql

models/stripe__invoice_details.sql

Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>

fivetran-avinash

@fivetran-savage Two small changes but lgtm afterward!

CHANGELOG.md

Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>

fivetran-savage added 6 commits January 29, 2026 13:02

feature/new_union_macro_metadata_fields_and_variable_configs

4c6bbef

add_variable_configs_to_downstream_models

ecf0a8e

add_charge_medatada_fields_to_end_model

9fdebec

add_union_macro_files

30a7a52

add_union_macro_files

41b2a9b

add_metadata_macro

aa8992c

fivetran-savage self-assigned this Feb 4, 2026

fivetran-savage added 8 commits February 4, 2026 15:00

update_charge_seed_column

5909cde

update_integration_test_seed_column_definitions

0ebd3b3

add_seed_column_details

6a73071

sdd_column_definitions

9e78db2

update_ci_folder

6276501

update_changelog_and_readme

d99a38c

update_column_definitions

33775f9

add_coupon_to_yml

6aca2b5

fivetran-joemarkiewicz self-requested a review February 6, 2026 22:01

fivetran-joemarkiewicz requested changes Feb 9, 2026

View reviewed changes

fivetran-savage added 10 commits February 9, 2026 13:09

update_quickstart_yml

893cb47

change_macro_link

3d4bafd

add_transfers_var_config

2eca5b8

update_readme

20a289a

change_order_of_tests

a20ba3d

add_vars_to_int_models

9fd63b2

adjust_jinja

81e4914

update_readme

3c6b49f

restore_changelog_history

a63f8ae

Restore changelog history

b261218

fivetran-joemarkiewicz requested changes Feb 11, 2026

View reviewed changes

fivetran-savage and others added 2 commits February 11, 2026 09:45

Apply suggestions from code review

fc48a1f

Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>

Update README

4e7276c

fivetran-savage and others added 2 commits February 11, 2026 11:58

Update CHANGELOG.md

89a843f

Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>

Update macros/select_metadata_columns.sql

87d5a6e

Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>

fivetran-joemarkiewicz reviewed Feb 11, 2026

View reviewed changes

fivetran-joemarkiewicz approved these changes Feb 11, 2026

View reviewed changes

fivetran-savage and others added 2 commits February 11, 2026 15:11

Apply suggestions from code review

a896abd

Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>

Update README

14c9fae

fivetran-savage added the docs:ready Triggers the docs generator workflow. label Feb 11, 2026

Generate dbt docs via GitHub Actions

385f4dd

fivetran-avinash reviewed Feb 12, 2026

View reviewed changes

fivetran-savage and others added 4 commits February 12, 2026 10:15

Apply suggestions from code review

90ee3d2

Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com> Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>

Update CHANGELOG

1dd6061

Apply suggestions from code review

73e539d

Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>

Remove select_metadata_columns macro from customer_overview

dc330d3

This comment was marked as off-topic.

Sign in to view

Update indentation

49688cd

fivetran-avinash reviewed Feb 12, 2026

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

fivetran-savage removed the docs:ready Triggers the docs generator workflow. label Feb 12, 2026

fivetran-savage and others added 4 commits February 12, 2026 11:27

Enhance CHANGELOG with model and Quickstart updates

b6fa2ec

Update CHANGELOG.md

80eaf64

Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>

Apply suggestions from code review

f7fc894

Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>

Fix indentation

55d143e

fivetran-avinash reviewed Feb 12, 2026

View reviewed changes

fivetran-savage and others added 2 commits February 12, 2026 15:06

update_changelog

d9ee75b

Update CHANGELOG.md

850761c

Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>

fivetran-avinash approved these changes Feb 12, 2026

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

Apply suggestions from code review

a65fc5f

Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>

fivetran-savage added the docs:ready Triggers the docs generator workflow. label Feb 12, 2026

Generate dbt docs via GitHub Actions

b010bba

fivetran-savage merged commit ee3b0bd into main Feb 13, 2026
9 checks passed

fivetran-savage deleted the feature/new_union_macro_metadata_fields_and_variable_configs branch February 13, 2026 00:05

Conversation

fivetran-savage commented Feb 4, 2026

PR Overview

Submission Checklist

Changelog

Uh oh!

fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

Uh oh!

fivetran-avinash left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fivetran-avinash Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as off-topic.

Uh oh!

Uh oh!

fivetran-avinash left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fivetran-avinash left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!