Skip to content

bug/gql-customer-cohorts#152

Open
fivetran-catfritz wants to merge 10 commits intomainfrom
bug/gql-customer-cohorts
Open

bug/gql-customer-cohorts#152
fivetran-catfritz wants to merge 10 commits intomainfrom
bug/gql-customer-cohorts

Conversation

@fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Mar 11, 2026

PR Overview

Package version introduced in this PR:

  • v1.6.0

This PR addresses the following Issue/Feature(s):

  • GA-1018752

Summary of changes:

  • Fixes an issue in the shopify_gql__customer_cohorts and shopify_gql__customer_email_cohorts models where incremental runs could result in records with a null cohort_month_number.

Submission Checklist

  • SHOPIFY-SPECIFIC: If you added a field to any model with metafields, did you increase the relevant column count in the downstream_model_column_count macro?
  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-catfritz fivetran-catfritz self-assigned this Mar 11, 2026
@fivetran-catfritz fivetran-catfritz added the pre-release Triggers the auto-releaser workflow. label Mar 11, 2026
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for pre-release. One changelog request/suggestion before proceeding forward.

@fivetran-catfritz fivetran-catfritz added docs:ready Triggers the docs generator workflow. and removed pre-release Triggers the auto-releaser workflow. labels Mar 11, 2026
@fivetran-catfritz fivetran-catfritz added the pre-release Triggers the auto-releaser workflow. label Mar 11, 2026
CHANGELOG.md Outdated

| Data Model(s) | Change type | Field | Old | New | Notes |
| --- | --- | --- | --- | --- | --- |
| `shopify_gql__customer_cohorts`<br>`shopify_gql__customer_email_cohorts`<br>`shopify__customer_email_cohorts` | Data quality | `cohort_month_number` | May contain null values on incremental runs | Properly calculated values | `--full-refresh` recommended |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `shopify_gql__customer_cohorts`<br>`shopify_gql__customer_email_cohorts`<br>`shopify__customer_email_cohorts` | Data quality | `cohort_month_number` | May contain null values on incremental runs | Properly calculated values | `--full-refresh` recommended |
| `shopify_gql__customer_cohorts`<br>`shopify_gql__customer_email_cohorts`<br>`shopify__customer_email_cohorts` | Data quality | `cohort_month_number`<br>`total_price_lifetime`<br>`order_count_lifetime`<br>`line_item_count_lifetime` | May contain null values on incremental runs | Properly calculated values | `--full-refresh` recommended |

@fivetran-catfritz fivetran-catfritz added pre-release Triggers the auto-releaser workflow. and removed pre-release Triggers the auto-releaser workflow. labels Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow. pre-release Triggers the auto-releaser workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants