Merged
Conversation
fivetran-joemarkiewicz
requested changes
Nov 10, 2025
Collaborator
fivetran-joemarkiewicz
left a comment
There was a problem hiding this comment.
@fivetran-savage thanks for working through these updates! A few change requests before approval.
fivetran-joemarkiewicz
requested changes
Nov 11, 2025
Collaborator
fivetran-joemarkiewicz
left a comment
There was a problem hiding this comment.
@fivetran-savage thanks for making these changes and it looks like you may have identified other issues and are addressing them in these updates. I have two remaining comments before approval. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
int_recurly__account_cumulativesSubmission Checklist -- IN JIRA
Confirmed that stuff works with the
grouptable on Snowflake by creating agroupand running this branch on that + the rest of the seed dataChangelog