Skip to content

feature-union-data#40

Merged
fivetran-savage merged 4 commits intomainfrom
feature/union-data
Nov 12, 2025
Merged

feature-union-data#40
fivetran-savage merged 4 commits intomainfrom
feature/union-data

Conversation

@fivetran-savage
Copy link
Copy Markdown
Contributor

PR Overview

Package version introduced in this PR:

  • 1.1.0

This PR addresses the following Issue/Feature(s):

Summary of changes:

  • Adds unioning capability
  • Corrects reference to credits instead of taxes in int_recurly__account_cumulatives

Submission Checklist -- IN JIRA

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention

Confirmed that stuff works with the group table on Snowflake by creating a group and running this branch on that + the rest of the seed data

  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

Copy link
Copy Markdown
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-savage thanks for working through these updates! A few change requests before approval.

Copy link
Copy Markdown
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-savage thanks for making these changes and it looks like you may have identified other issues and are addressing them in these updates. I have two remaining comments before approval. Thanks!

Copy link
Copy Markdown
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fivetran-savage fivetran-savage added the docs:ready Triggers the docs generator workflow. label Nov 12, 2025
@fivetran-savage fivetran-savage merged commit bd6195f into main Nov 12, 2025
9 checks passed
@fivetran-savage fivetran-savage deleted the feature/union-data branch November 12, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants