[Bug fix] Incremental irregularities#170
Merged
fivetran-avinash merged 18 commits intomainfrom Mar 4, 2026
Merged
Conversation
fivetran-jamie
approved these changes
Feb 17, 2026
Contributor
fivetran-jamie
left a comment
There was a problem hiding this comment.
Looks good for pre-release!
Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
Contributor
fivetran-jamie
left a comment
There was a problem hiding this comment.
Approved with two questions!
CHANGELOG.md
Outdated
|
|
||
| | Data Model(s) | Change type | Old | New | Notes | | ||
| | ---------- | ----------- | -------- | -------- | ----- | | ||
| | `jira__daily_issue_field_history` | Incremental filter fix (**Breaking Change**) | Filtered by `date_day >= max_date_week` | Filtered by `date_week >= max_date_week` | Aligns the incremental filter with the model's weekly partition key. Previously, the wrong column was used, which could cause data loss during partition overwrites on incremental runs. A full refresh is recommended to backfill any records that may have been missed. | |
Contributor
There was a problem hiding this comment.
Suggested change
| | `jira__daily_issue_field_history` | Incremental filter fix (**Breaking Change**) | Filtered by `date_day >= max_date_week` | Filtered by `date_week >= max_date_week` | Aligns the incremental filter with the model's weekly partition key. Previously, the wrong column was used, which could cause data loss during partition overwrites on incremental runs. A full refresh is recommended to backfill any records that may have been missed. | | |
| | `jira__daily_issue_field_history` | Incremental filter fix (**Breaking Change**) | Filtered by `date_day >= max_date_week` | Filtered by `date_week >= max_date_week` | Aligns the incremental filter with the model's weekly partition key. The previous filter could cause data loss during partition overwrites on incremental runs. A full refresh is recommended to backfill any records that may have been missed. | |
Also, since partitions are only applied in BigQuery and Databricks, was the bug only present in those warehouses? If so, we may want to note that (though a full refresh is required regardless of destination I think)
Contributor
Author
There was a problem hiding this comment.
Good call out, update applied.
fivetran-jamie
approved these changes
Mar 2, 2026
fivetran-savage
approved these changes
Mar 4, 2026
Contributor
fivetran-savage
left a comment
There was a problem hiding this comment.
One tiny suggestion but nothing holding up approval.
Co-authored-by: Savage Fivetran <sarah.savage@fivetran.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
Submission Checklist
Changelog