Skip to content

[Bug fix] Incremental irregularities#170

Merged
fivetran-avinash merged 18 commits intomainfrom
bugfix/incremental-irregularities
Mar 4, 2026
Merged

[Bug fix] Incremental irregularities#170
fivetran-avinash merged 18 commits intomainfrom
bugfix/incremental-irregularities

Conversation

@fivetran-avinash
Copy link
Copy Markdown
Contributor

@fivetran-avinash fivetran-avinash commented Feb 17, 2026

PR Overview

Package version introduced in this PR:

  • 1.6.0 (1.5.1-a1 for pre-release)

This PR addresses the following Issue/Feature(s):

  • GA-1016729

Summary of changes:

  • Updated incremental granularity to avoid partitions removing updated records.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-avinash fivetran-avinash self-assigned this Feb 17, 2026
@fivetran-avinash fivetran-avinash added the docs:ready Triggers the docs generator workflow. label Feb 17, 2026
Copy link
Copy Markdown
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for pre-release!

Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
@fivetran-avinash fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Feb 17, 2026
@fivetran-avinash fivetran-avinash added the pre-release Triggers the auto-releaser workflow. label Feb 17, 2026
@fivetran-avinash fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. pre-release Triggers the auto-releaser workflow. labels Feb 25, 2026
Copy link
Copy Markdown
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with two questions!

CHANGELOG.md Outdated

| Data Model(s) | Change type | Old | New | Notes |
| ---------- | ----------- | -------- | -------- | ----- |
| `jira__daily_issue_field_history` | Incremental filter fix (**Breaking Change**) | Filtered by `date_day >= max_date_week` | Filtered by `date_week >= max_date_week` | Aligns the incremental filter with the model's weekly partition key. Previously, the wrong column was used, which could cause data loss during partition overwrites on incremental runs. A full refresh is recommended to backfill any records that may have been missed. |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `jira__daily_issue_field_history` | Incremental filter fix (**Breaking Change**) | Filtered by `date_day >= max_date_week` | Filtered by `date_week >= max_date_week` | Aligns the incremental filter with the model's weekly partition key. Previously, the wrong column was used, which could cause data loss during partition overwrites on incremental runs. A full refresh is recommended to backfill any records that may have been missed. |
| `jira__daily_issue_field_history` | Incremental filter fix (**Breaking Change**) | Filtered by `date_day >= max_date_week` | Filtered by `date_week >= max_date_week` | Aligns the incremental filter with the model's weekly partition key. The previous filter could cause data loss during partition overwrites on incremental runs. A full refresh is recommended to backfill any records that may have been missed. |

Also, since partitions are only applied in BigQuery and Databricks, was the bug only present in those warehouses? If so, we may want to note that (though a full refresh is required regardless of destination I think)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call out, update applied.

@fivetran-avinash fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Mar 3, 2026
Copy link
Copy Markdown
Contributor

@fivetran-savage fivetran-savage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny suggestion but nothing holding up approval.

Co-authored-by: Savage Fivetran <sarah.savage@fivetran.com>
@fivetran-avinash fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Mar 4, 2026
@fivetran-avinash fivetran-avinash merged commit 858bafb into main Mar 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants