Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

Dynamically handle creative_history.url_tags as a json or string in BQ #43

Merged
fivetran-jamie merged 8 commits intomainfrom
update/json-variable
Mar 13, 2025
Merged

Dynamically handle creative_history.url_tags as a json or string in BQ #43
fivetran-jamie merged 8 commits intomainfrom
update/json-variable

Conversation

@fivetran-jamie
Copy link
Copy Markdown
Contributor

@fivetran-jamie fivetran-jamie commented Mar 11, 2025

PR Overview

This PR will address the following Issue/Feature:
#42
fivetran/dbt_facebook_ads#28
#39

Submission Checklist

Submitter:

  • Alignment meeting with the reviewer
  • Provide validation details:
    • Validation Steps:

      • Transformation Validation tests pass (will share schema I ran this on in Height):
        image
      • BK is passing - this shouldn't affect the other warehouses at all
    • Testing Instructions: I will provide schemas to run this on (with a JSON or STRING version of the field) in Height

      • Running the prod version of facebook_ads on a schema with a JSON field:
        image
      • Running the dev version of facebook_ads (reliant on this facebook_ads_source branch) on a schema with a JSON field:
        image
      • Running the prod version of facebook_ads on a schema with a STRING field:
        image
      • Running the dev version of facebook_ads (reliant on this facebook_ads_source branch) on a schema with a STRING field:
        image
    • Focus Areas: Everything is pretty isolated to the creative_history staging model.

Reviewer:

  • Confirm submission requirements are met

Changelog

  • Draft after PR approval - somewhat drafted already but will confirm later

Copy link
Copy Markdown
Contributor

@fivetran-reneeli fivetran-reneeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with just 1 minor suggestion! Great work on the dynamic logic!

Copy link
Copy Markdown
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good! Just one clarifying question before approval.

Copy link
Copy Markdown
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fivetran-jamie fivetran-jamie merged commit a772653 into main Mar 13, 2025
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

3 participants