This repository was archived by the owner on Jan 20, 2026. It is now read-only.
Dynamically handle creative_history.url_tags as a json or string in BQ #43
Merged
fivetran-jamie merged 8 commits intomainfrom Mar 13, 2025
Merged
Dynamically handle creative_history.url_tags as a json or string in BQ #43fivetran-jamie merged 8 commits intomainfrom
creative_history.url_tags as a json or string in BQ #43fivetran-jamie merged 8 commits intomainfrom
Conversation
This was
linked to
issues
Mar 12, 2025
fivetran-reneeli
approved these changes
Mar 12, 2025
Contributor
fivetran-reneeli
left a comment
There was a problem hiding this comment.
Looks good with just 1 minor suggestion! Great work on the dynamic logic!
Contributor
fivetran-joemarkiewicz
left a comment
There was a problem hiding this comment.
This PR looks good! Just one clarifying question before approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
#42
fivetran/dbt_facebook_ads#28
#39
Submission Checklist
Submitter:
Validation Steps:
Testing Instructions: I will provide schemas to run this on (with a JSON or STRING version of the field) in Height
facebook_adson a schema with a JSON field:facebook_ads(reliant on thisfacebook_ads_sourcebranch) on a schema with a JSON field:facebook_adson a schema with a STRING field:facebook_ads(reliant on thisfacebook_ads_sourcebranch) on a schema with a STRING field:Focus Areas: Everything is pretty isolated to the
creative_historystaging model.Reviewer:
Changelog