Skip to content

update_readme_disable_semantic_models#171

Merged
fivetran-savage merged 6 commits intomainfrom
update_readme_disable_semantic_models
Feb 14, 2026
Merged

update_readme_disable_semantic_models#171
fivetran-savage merged 6 commits intomainfrom
update_readme_disable_semantic_models

Conversation

@fivetran-savage
Copy link
Contributor

PR Overview

Package version introduced in this PR:

  • N/A Readme Only

This PR addresses the following Issue/Feature(s):

Summary of changes:

  • Updates README.md with instructions as to how to disable semantic models.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few change requests before approval

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-savage after looking at the changes in the rendered README, it didn't look right. I noticed an issue and called out the fixes below.

fivetran-savage and others added 3 commits February 13, 2026 14:56
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fivetran-savage fivetran-savage merged commit 711b208 into main Feb 14, 2026
8 checks passed
@fivetran-savage fivetran-savage deleted the update_readme_disable_semantic_models branch February 14, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants