interpolate: sanitise submesh interpolate #4482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksagiyam
force-pushed
the
ksagiyam/sanitize_submesh_interp
branch
4 times, most recently
from
9293fb4 to
6c76fef
Compare
ksagiyam
force-pushed
the
ksagiyam/sanitize_submesh_interp
branch
from
6c76fef to
77a73f2
Compare
dham
previously approved these changes
Aug 13, 2025
|
@connorjward I wanted to refactor a little and add stricter checks. Can you check the diff? |
connorjward
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let one pass
allow_missing_dofs=Trueto let Firedrake automatically make appropriatesubsetwhen interpolating between submeshes.