feat: Add MCP protocol regression tests#175
Open
caballeto wants to merge 1 commit intofirecrawl:mainfrom
Open
Conversation
caballeto
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
No regression tests exist - CI only runs
pnpm build. When schemas or tools change, tool calls can break silently.Solution
Adds snapshot-based regression tests that verify the MCP protocol surface - handshake, tool schemas, and error handling on every PR. Any change to a tool name, parameter type, or schema shows up as a diff in CI.
Zero changes to existing files. Adds a standalone
integration.ymlworkflow.Uses mcp-recorder for recording and verification. No Firecrawl API key needed in CI, the server runs with a dummy key.
Updating cassettes after intentional changes:
mcp-recorder verify --cassette ... --target ... --updateTest plan