Fix: Resolve localStorage SSR errors for Node.js v22/v25 compatibility#30
Open
domfahey wants to merge 2 commits intofirecrawl:mainfrom
Open
Fix: Resolve localStorage SSR errors for Node.js v22/v25 compatibility#30domfahey wants to merge 2 commits intofirecrawl:mainfrom
domfahey wants to merge 2 commits intofirecrawl:mainfrom
Conversation
- Add safe localStorage utility (lib/utils/storage.ts) with SSR checks - Replace direct localStorage calls with getLocalStorageItem/setLocalStorageItem helpers - Add comprehensive CLAUDE.md documentation for codebase architecture - Update package-lock.json and pnpm-lock.yaml for Node.js v22 This fixes "localStorage.getItem is not a function" errors caused by Next.js 15 incompatibility with Node.js v25. The new storage utility properly checks for window.localStorage availability and function types before accessing, ensuring compatibility across server and client environments. Files changed: - app/page.tsx: Use storage helpers in useEffect and event handlers - app/fire-enrich/page.tsx: Use storage helpers for API key management - app/fire-enrich/enrichment-table.tsx: Use storage helpers in callbacks - lib/utils/storage.ts: New safe localStorage wrapper with SSR guards - CLAUDE.md: Complete architecture documentation and troubleshooting guide 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes localStorage SSR errors that occur when using Next.js 15 with Node.js v25 by implementing safe localStorage access utilities and comprehensive documentation.
Key Changes:
- Created a new
lib/utils/storage.tsmodule with SSR-safe localStorage wrappers that check for browser environment and function availability - Replaced all direct
localStoragecalls across three components with the new safe utilities - Added complete
CLAUDE.mddocumentation covering architecture, development workflows, and Node.js compatibility requirements
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/utils/storage.ts | New utility module with SSR-safe localStorage wrapper functions |
| app/page.tsx | Updated to use safe localStorage utilities for API key retrieval and storage |
| app/fire-enrich/page.tsx | Updated to use safe localStorage utilities for API key retrieval and storage |
| app/fire-enrich/enrichment-table.tsx | Updated to use safe localStorage utilities for API key retrieval |
| CLAUDE.md | Comprehensive documentation of codebase architecture, development commands, and requirements |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localStorage.getItem is not a functionerrors in Next.js 15Problem
Next.js 15 with Node.js v25 causes SSR errors when accessing localStorage:
localStorage.getItem is not a function--localstorage-file was provided without a valid pathThis occurs because Node.js v25 provides a broken localStorage polyfill during server-side rendering.
Solution
Created
lib/utils/storage.ts- Safe localStorage wrapper that:typeof window !== 'undefined'window.localStorageexists and has correct function typesnullsafely when localStorage is unavailableUpdated all localStorage calls in:
app/page.tsx- Main page componentapp/fire-enrich/page.tsx- Fire Enrich pageapp/fire-enrich/enrichment-table.tsx- Enrichment table componentAdded CLAUDE.md - Complete codebase documentation including:
Node.js Compatibility
Test Plan
Breaking Changes
None - this is a bug fix that improves SSR compatibility.
Additional Notes
The
package-lock.jsonwas updated after switching to Node.js v22, which is the recommended version for Next.js 15.🤖 Generated with Claude Code