fix(cli): use custom polling for --wait without --progress flag#81
Open
cyphercodes wants to merge 1 commit intofirecrawl:mainfrom
Open
fix(cli): use custom polling for --wait without --progress flag#81cyphercodes wants to merge 1 commit intofirecrawl:mainfrom
cyphercodes wants to merge 1 commit intofirecrawl:mainfrom
Conversation
Fixes #3210 The --wait flag without --progress was using app.crawl() which relies on SDK's built-in polling that doesn't work with self-hosted instances. This change makes both --wait and --wait --progress use the same custom polling loop that works correctly with both cloud and self-hosted APIs. Changes: - Always use custom polling loop for --wait mode - Only show progress output when --progress flag is specified - Fixes indefinite hang on self-hosted instances
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3210
The
--waitflag without--progresswas usingapp.crawl()which relies on SDK's built-in polling that doesn't work with self-hosted instances (likely due to RabbitMQ LISTEN/NOTIFY vs HTTP polling mismatch).Changes
--waitmode (works with both cloud and self-hosted)--progressflag is specifiedfirecrawl crawl <url> --waitTesting
firecrawl crawl <url> --waitnow works correctly on self-hosted instancesfirecrawl crawl <url> --wait --progresscontinues to work as beforeRelated
Closes #3210