Skip to content

[OC-7791] Tokenization - Updated deserialization for stricter parsing #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[OC-7791] Tokenization - Updated deserialization for stricter parsing #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions src/main/java/com/fireblocks/sdk/model/TokenLinkDtoTokenMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import com.fasterxml.jackson.databind.annotation.JsonSerialize;
import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
import com.fasterxml.jackson.databind.ser.std.StdSerializer;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fireblocks.sdk.JSON;
import java.io.IOException;
import java.util.Collections;
Expand Down Expand Up @@ -78,6 +79,8 @@ public TokenLinkDtoTokenMetadata deserialize(JsonParser jp, DeserializationConte
boolean typeCoercion = ctxt.isEnabled(MapperFeature.ALLOW_COERCION_OF_SCALARS);
int match = 0;
JsonToken token = tree.traverse(jp.getCodec()).nextToken();
ObjectMapper objectMapper = new ObjectMapper();

// deserialize AssetMetadataDto
try {
boolean attemptParsing = true;
Expand Down Expand Up @@ -108,10 +111,7 @@ public TokenLinkDtoTokenMetadata deserialize(JsonParser jp, DeserializationConte
}
}
if (attemptParsing) {
deserialized = tree.traverse(jp.getCodec()).readValueAs(AssetMetadataDto.class);
// TODO: there is no validation against JSON schema constraints
// (min, max, enum, pattern...), this does not perform a strict JSON
// validation, which means the 'match' count may be higher than it should be.
deserialized = objectMapper.readValue(tree.traverse(jp.getCodec()), AssetMetadataDto.class);
match++;
log.log(Level.FINER, "Input data matches schema 'AssetMetadataDto'");
}
Expand Down Expand Up @@ -150,11 +150,7 @@ public TokenLinkDtoTokenMetadata deserialize(JsonParser jp, DeserializationConte
}
}
if (attemptParsing) {
deserialized =
tree.traverse(jp.getCodec()).readValueAs(CollectionMetadataDto.class);
// TODO: there is no validation against JSON schema constraints
// (min, max, enum, pattern...), this does not perform a strict JSON
// validation, which means the 'match' count may be higher than it should be.
deserialized = objectMapper.readValue(tree.traverse(jp.getCodec()), CollectionMetadataDto.class);
match++;
log.log(Level.FINER, "Input data matches schema 'CollectionMetadataDto'");
}
Expand Down Expand Up @@ -193,11 +189,7 @@ public TokenLinkDtoTokenMetadata deserialize(JsonParser jp, DeserializationConte
}
}
if (attemptParsing) {
deserialized =
tree.traverse(jp.getCodec()).readValueAs(ContractMetadataDto.class);
// TODO: there is no validation against JSON schema constraints
// (min, max, enum, pattern...), this does not perform a strict JSON
// validation, which means the 'match' count may be higher than it should be.
deserialized = objectMapper.readValue(tree.traverse(jp.getCodec()), ContractMetadataDto.class);
match++;
log.log(Level.FINER, "Input data matches schema 'ContractMetadataDto'");
}
Expand Down