Add assetId flag to allow for using networks not in the defaults list #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@orenyomtov, since you helped me out with fireblocks/fireblocks-web3-provider#60, maybe you have context and can decide if this looks good to you. I'd definitely prefer to get this fixed as its been a pain point for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CLI uses the list in
fireblocks-web3-providerto resolve the asset ID for a given network. This list does not include all assets/networks supported by Fireblocks. This PR adds anassetIdflag to the CLI options to allow for manually specifying the asset ID when it is missing fromfireblocks-web3-provider.I've run into this issue a few times now and have previously fixed it by modifying the code in
fireblocks-web3-provider(see fireblocks/fireblocks-web3-provider#60 ). This PR provides a solution that will allow me to stop monkey-patchingfireblocks-web3-providerwhen it doesn't contain the asset I am trying to use in its defaults list.