[CI] Run all macos-15 jobs with Xcode 16.4
#1748
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @andrewheard, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the continuous integration (CI) configuration for macos-15 jobs to utilize Xcode 16.4 instead of Xcode 16.2. This change is necessary because Xcode 16.2 on macOS 15 no longer bundles the required platform tools and simulator runtimes, which are now exclusively available in more recent Xcode versions (16.3, 16.4, and 26 Beta). The update ensures that CI builds and tests can continue to run successfully by using a compatible Xcode environment.
Highlights
- CI Configuration Update: The primary change involves updating the CI setup to use Xcode 16.4 for macos-15 based jobs.
- Xcode Version Dependency: This update addresses the issue where Xcode 16.2 on macOS 15 no longer includes necessary platform tools and simulator runtimes, which are now only available in Xcode 16.3, 16.4, and 26 Beta.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly updates the Xcode version to 16.4 for macos-15 jobs. My review focuses on improving maintainability by addressing the hardcoded Xcode version string. The version is now present in two separate files, which could make future updates error-prone. I've added suggestions to introduce variables for the version number in each script. For a more robust long-term solution, you might consider centralizing the Xcode version definition in a single shared script that both CI scripts can source.
Updated all
macos-15jobs to use Xcode 16.4 instead of 16.2 since the platforms/simulators are now only included in Xcode 16.3, 16.4 and 26 Beta. The alternative would be to install the platforms with, e.g.,xcodebuild -downloadPlatform iOSto continue using 16.2 on macOS 15.