-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Clarify swizzling requirement for APNs token registration in AppDelegate #1740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Clarify swizzling requirement for APNs token registration in AppDelegate #1740
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Preacher999987, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on improving the clarity of documentation within the AppDelegate.swift
file in the MessagingExampleSwift
project. The primary goal is to correct and clarify the understanding of how APNs device token registration interacts with Firebase Messaging, specifically addressing the requirement for a certain AppDelegate
method even when method swizzling is enabled.
Highlights
- Documentation Clarity: Updated comments in
AppDelegate.swift
to explicitly state that theapplication(_:didRegisterForRemoteNotificationsWithDeviceToken:)
method must still be declared, even when Firebase Messaging's method swizzling is enabled. This clarifies that Firebase uses this method internally to intercept and register the APNs device token, and its omission would prevent token reception.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request provides a helpful clarification in the comments regarding the necessity of implementing application(_:didRegisterForRemoteNotificationsWithDeviceToken:)
even when method swizzling is enabled in Firebase Messaging. The previous comment was misleading, and this change improves the clarity of the example code. I have one minor suggestion regarding code formatting to maintain consistency.
@@ -99,8 +99,11 @@ class AppDelegate: UIResponder, UIApplicationDelegate { | |||
didFailToRegisterForRemoteNotificationsWithError error: Error) { | |||
print("Unable to register for remote notifications: \(error.localizedDescription)") | |||
} | |||
|
|||
// This function is added here only for debugging purposes, and can be removed if swizzling is enabled. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line contains a tab character, which is likely unintentional for a blank line. Swift style guides, such as the Google Swift Style Guide, recommend using spaces over tabs for consistency. Mixed whitespace can lead to formatting issues across different editors and environments. Please remove the tab character to make this a truly empty line.
Clarify swizzling requirement for APNs token registration in AppDelegate