Skip to content

fix(genkit-tools/generate): Make model optional #3918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssbushi merged 9 commits into from
Dec 12, 2025
Merged

fix(genkit-tools/generate): Make model optional #3918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5ecdefa
undo py changes
ssbushi Dec 10, 2025
39b8b8d
py
ssbushi Dec 10, 2025
1881b26
uv lock
ssbushi Dec 10, 2025
3af3714
merge
ssbushi Dec 12, 2025
01b56c2
lock
ssbushi Dec 12, 2025
d13a9a3
fixed lock
pavelgj Dec 12, 2025
3456ec8
undo lock file
pavelgj Dec 12, 2025
385cb1c
undo better
pavelgj Dec 12, 2025
537e23a
undo gen
pavelgj Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion genkit-tools/common/src/types/model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ export const GenerateActionOutputConfig = z.object({

export const GenerateActionOptionsSchema = z.object({
/** A model name (e.g. `vertexai/gemini-1.0-pro`). */
model: z.string(),
model: z.string().optional(),
/** Retrieved documents to be used as context for this generation. */
docs: z.array(DocumentDataSchema).optional(),
/** Conversation history for multi-turn prompting when supported by the underlying model. */
Expand Down
1 change: 0 additions & 1 deletion genkit-tools/genkit-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,6 @@
}
},
"required": [
"model",
"messages"
],
"additionalProperties": false
Expand Down
2 changes: 1 addition & 1 deletion py/packages/genkit/src/genkit/core/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,7 +951,7 @@ class GenerateActionOptions(BaseModel):
"""Model for generateactionoptions data."""

model_config = ConfigDict(extra='forbid', populate_by_name=True)
model: str
model: str | None = None
docs: list[DocumentData] | None = None
messages: list[Message]
tools: list[str] | None = None
Expand Down
Loading