fix(vertexai): correct URL construction for global endpoint #3913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
When location is set to 'global', the plugin was incorrectly constructing the URL as https://global-aiplatform.googleapis.com, which results in 404. The correct URL for global endpoint should be https://aiplatform.googleapis.com without the location prefix. This fix applies to: - list-models.ts: Model listing endpoint - upsert_datapoints.ts: Vector search datapoint upsert endpoint - predict.ts: Prediction endpoint - evaluation/evaluator_factory.ts: Evaluation service endpoint - modelgarden/v2/llama.ts: Llama model garden endpoint Implementation uses a ternary operator for optimal performance and follows the same pattern as Google's official Gen AI SDK. Fixes firebase#3651
yeonjaee
force-pushed
the
fix/global-location-url
branch
from
cb00fd1 to
ad30100
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3651
Problem
When
location: 'global'is specified in the Vertex AI plugin, the URL is incorrectly constructed ashttps://global-aiplatform.googleapis.com, which leads to a 404 error. The correct endpoint for global location should behttps://aiplatform.googleapis.com.Solution
This PR updates the URL construction logic to handle the
globallocation case correctly by removing the location prefix from the domain while keeping it in the path where necessary (e.g.locations/global).The fix applies to:
For llama.ts, the template logic was updated to use a domain without the location prefix when the location is global, while preserving the path structure.
Implementation follows the pattern used in the official Google Gen AI SDK.
Checklist