Skip to content

feat(py/genkit): added the resolve_method for openai compatible plugin #3055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 15, 2025

Conversation

hendrixmar
Copy link
Contributor

Description:

This PR introduces the concrete implementation of the resolve_method for the OpenAI compat plugin.

@hendrixmar hendrixmar requested a review from pavelgj as a code owner June 10, 2025 19:17
@github-actions github-actions bot added feature New feature or request python Python labels Jun 10, 2025
@AbeJLazaro
Copy link
Contributor

Let's check if it is required to keep using the handler. I think the model generate method is enough, and the handler is only a wrapper to determine which models are valid based on the supported models variable. We are going to deprecate those validations, so maybe the handler is not required.

@hendrixmar hendrixmar force-pushed the hendrixmar/feature/add_resolve_action_openai_compat branch from 7792386 to e0d8647 Compare June 13, 2025 17:31
@AbeJLazaro AbeJLazaro enabled auto-merge (squash) June 16, 2025 14:48
@AbeJLazaro AbeJLazaro requested a review from pavelgj June 16, 2025 15:58
@github-actions github-actions bot added docs Improvements or additions to documentation sample labels Jun 20, 2025
@hendrixmar hendrixmar force-pushed the hendrixmar/feature/add_resolve_action_openai_compat branch from 69bdaa5 to 052b712 Compare June 20, 2025 16:21
@hendrixmar hendrixmar requested a review from ssbushi as a code owner July 15, 2025 14:53
@AbeJLazaro AbeJLazaro merged commit 91478eb into main Jul 15, 2025
5 of 9 checks passed
@AbeJLazaro AbeJLazaro deleted the hendrixmar/feature/add_resolve_action_openai_compat branch July 15, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config docs Improvements or additions to documentation feature New feature or request go js python Python root sample tooling
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants