-
Notifications
You must be signed in to change notification settings - Fork 326
feat(py/genkit): added the resolve_method for openai compatible plugin #3055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AbeJLazaro
merged 6 commits into
main
from
hendrixmar/feature/add_resolve_action_openai_compat
Jul 15, 2025
Merged
feat(py/genkit): added the resolve_method for openai compatible plugin #3055
AbeJLazaro
merged 6 commits into
main
from
hendrixmar/feature/add_resolve_action_openai_compat
Jul 15, 2025
+162
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbeJLazaro
reviewed
Jun 10, 2025
AbeJLazaro
reviewed
Jun 10, 2025
py/plugins/compat-oai/src/genkit/plugins/compat_oai/openai_plugin.py
Outdated
Show resolved
Hide resolved
AbeJLazaro
reviewed
Jun 11, 2025
py/plugins/compat-oai/src/genkit/plugins/compat_oai/openai_plugin.py
Outdated
Show resolved
Hide resolved
AbeJLazaro
reviewed
Jun 11, 2025
AbeJLazaro
reviewed
Jun 11, 2025
Let's check if it is required to keep using the handler. I think the model generate method is enough, and the handler is only a wrapper to determine which models are valid based on the supported models variable. We are going to deprecate those validations, so maybe the handler is not required. |
7792386
to
e0d8647
Compare
AbeJLazaro
approved these changes
Jun 13, 2025
pavelgj
reviewed
Jun 16, 2025
py/plugins/compat-oai/src/genkit/plugins/compat_oai/openai_plugin.py
Outdated
Show resolved
Hide resolved
69bdaa5
to
052b712
Compare
AbeJLazaro
reviewed
Jun 23, 2025
py/plugins/compat-oai/src/genkit/plugins/compat_oai/openai_plugin.py
Outdated
Show resolved
Hide resolved
AbeJLazaro
reviewed
Jun 23, 2025
py/plugins/compat-oai/src/genkit/plugins/compat_oai/openai_plugin.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces the concrete implementation of the resolve_method for the OpenAI compat plugin.