feat(go):Support custom configs for all primitives #2883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apascal07
reviewed
May 27, 2025
apascal07
requested changes
May 27, 2025
apascal07
reviewed
Jun 11, 2025
apascal07
reviewed
Jun 25, 2025
go/ai/embedder.go
Outdated
| } | ||
|
|
||
| type EmbedderOptions struct { | ||
| ConfigSchema any `json:"configSchema,omitempty"` |
There was a problem hiding this comment.
This field is either misnamed or should be a map[string]any. Schema implies it itself is a schema but based on the code, it seems like we're expecting a value that we then infer the schema of. Probably should just be Config. Please add a comment explaining what is meant to go into it.
There was a problem hiding this comment.
ConfigSchema is to hold the schema for the config in embedder i am not getting when you say it should be map[string]any as it will create problem as we are mapping different config schema directly in each plugin.
apascal07
reviewed
Jun 25, 2025
apascal07
previously requested changes
Jun 25, 2025
|
Please re-request review when you are done making changes so this ends up in my inbox. |
sahdev77
dismissed
apascal07’s stale review
sample app have the usage of config of embedder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition and handling of custom config for Embedder and Retriever for all the plugins
Bug: #2444
Checklist (if applicable):