Skip to content

ci(swift): use PR branch to test swift integration rather than version #17460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2025

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jun 27, 2025

Description

  • Using version isn't a good idea particularly if there is an update to the code without a version. Preferable to test against any changes in the pull request.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title ci: use PR branch to test swift integration rather than version that … ci: use PR branch to test swift integration rather than version Jun 27, 2025
@russellwheatley russellwheatley changed the title ci: use PR branch to test swift integration rather than version ci(swift): use PR branch to test swift integration rather than version Jun 27, 2025
@russellwheatley russellwheatley marked this pull request as ready for review June 27, 2025 09:15
@russellwheatley russellwheatley requested a review from Lyokone as a code owner June 27, 2025 09:15
@russellwheatley russellwheatley merged commit 6b78b5d into main Jun 27, 2025
29 of 31 checks passed
@russellwheatley russellwheatley deleted the ci-swift-integration branch June 27, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants