Skip to content

fix(messaging): macos incorrect parsing of notification response … #17231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+3 −1
Open

fix(messaging): macos incorrect parsing of notification response … #17231

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e05836
fix: incorrect parsing of notification response in application_onDidF…
steffenhaak Mar 24, 2025
c64982a
fix: clang-format for code style
steffenhaak Jun 26, 2025
3afce9b
Merge branch 'firebase:main' into fix/macos-notification-click
steffenhaak Jul 16, 2025
4f0889f
remote-tracking branch 'origin/main' into fix/macos-notification-click
MichaelVerdon Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ..._messaging/ios/firebase_messaging/Sources/firebase_messaging/FLTFirebaseMessagingPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,8 @@ - (void)messaging:(nonnull FIRMessaging *)messaging
- (void)application_onDidFinishLaunchingNotification:(nonnull NSNotification *)notification {
// Setup UIApplicationDelegate.
#if TARGET_OS_OSX
NSDictionary *remoteNotification = notification.userInfo[NSApplicationLaunchUserNotificationKey];
UNNotificationResponse *notificationResponse = notification.userInfo[NSApplicationLaunchUserNotificationKey];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, I am sorry I did not see this sooner. It looks alright to me. Can I get you to fix formatting issues that occured on CI? Should be very quick.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MichaelVerdon , I am very sorry, I unfortunately lost sight of your message. I just ran clang-format (see latest commit), so the tests now should pass. Can you approve another test run?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelVerdon Ping :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there thanks for the ping @steffenhaak I will be checking this out properly

NSDictionary *remoteNotification = notificationResponse.notification.request.content.userInfo;
#else
NSDictionary *remoteNotification =
notification.userInfo[UIApplicationLaunchOptionsRemoteNotificationKey];
Expand Down
Loading